/
2022-06-08 Interfaces review, Acceptance criteria, Definition of Done

2022-06-08 Interfaces review, Acceptance criteria, Definition of Done

Owned by Julia Boyarshchikova (Deactivated)
Last updated: Jun 10, 2022 by Nick Harris
2 min read

Participants

Reckitt (RB):

  • Nathan McKean

  • Nick Harris

  • Matt Lau

  • Ben Wilson

  • Robert Ruszczyk

  • Radoslaw Kowalewski

  • Bartlomiej Kusmierczuk

DataArt (DA):

  • Sergey Kiselyov

  • Anton Merkulov

  • Sergey Gromskiy

  • Nikita Puzyrenko

  • Alexander Kostylev

  • Julia Boyarshchikova

  • Sergiy Nalyvayko

 Action items

 

To fix Nav link issue Design issues (line 8) @ben.wilson@inviqa.com
To review subtle button issue within Accordion (the outline area shown on hover is much longer than the button text) @nathan.mckean@reckitt.com (Unlicensed)
To make for Accordion in expandVariant ‘multiple’ as the default option @Alexander Kostylev (Unlicensed)
To remove ‘variant’ prop from Accordion and create a separate component named ‘Disclosure’ @Alexander Kostylev (Unlicensed)
To review Acceptance Criteria of the components shared in the separate email thread @Nick Harris
To give formal approval to Accordion interface @Nick Harris

Key takeaways

 

  1.    Accordion props review.

  • semanticVariant. Nathan's point is that variants should be accompanied by some sort of discription of when and for which case each of the variants should be used.  The option name can be changed without breaking the code.

  • expandVariant. Controls expanding accordion items. "single" - only one accordion item, "multiple" all accordion items at the same time. ‘multiple’ should be by default.

  • className. No comments.

  • openIcon, closeIcon. Nick: we should add to description that icon can be used from the Icon component.

  • headlineTag. No comments.

  • expandedIndex. No comments.

  • onChange. No comments.

  • variant. It was decided to create Disclosure component out of Subtle variant and remove variants from Accordion

Meeting recording