...
Component | Issue | Status | Notes | |||||||
|---|---|---|---|---|---|---|---|---|---|---|
| 1 | Button | Button text is centred. Is this the design intention? Should it be a variable/token? (Does it look weird being centred if wrapping to two rows? Yes, icon only can be centred - but the other should be discussed. |
| James to create a mockup for two line button. Two lines - text left aligned. Icon on the first line. | ||||||
| 2 | Button | Nav style button padding appears to include a 1px padding. This is not a spacer value and is likely a design error that could be tweaked. |
| Outline style for all elements - change to 2px 4px. | ||||||
| 3 | Button | The outline offset for nav is hard coded at 1px. On other variant styles it is 4px. What is the reason that we don't have a common default value for styles like this? It doesn't look like line size, style, colour, outline value etc is referencing common token values to centralise the styles rather than adding them individually for each state. |
| Outline style for all elements - change to 2px 4px | ||||||
| 4 | Link | Nav style link padding appears to include a 2px & 3px padding. This is not a spacer value and is likely a design error that could be tweaked. |
| Outline style for all elements - change to 2px 4px | ||||||
| 5 | Image + Text | Inset variant. What is that bigger text in description ? |
| Add body text in development | ||||||
| 6 | Promo strip | I think actually maybe there is a logic error here in the design and that what is shown in the design as the background image should actually be for a foreground image as that is more important. Background images are more decorational. That foreground image can then maintain its native aspect ratio, but have a max width and max height defined to constrain it. Whilst you could do logic to show a bg image in the absence of a foreground image, that logic may be unnecessary until we have a request for it. From the designs, it actually looks to me that the height of the image is bounded by the text box height, but I could be wrong. Regardless, the alignment of image, text and CTA appear off and should get a design opinion. |
| |||||||
| 7 | Teasers | Design of Teaser does not reflect the approach for full-width and inseet versions for each variant. Instead Hero Promo and Teaser 1 are considered as two different variant, whereas it should be one variant in two sizes. |
| |||||||
| 8 | Skip to content | Revisit skip to link desing |
| |||||||
| 9 | Teaser 2/Promo Strip | Disclaimer should be added at the bottom |
|
...