Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Component

Issue

Status

Notes

1

Button

Button text is centred. Is this the design intention? Should it be a variable/token? (Does it look weird being centred if wrapping to two rows? Yes, icon only can be centred - but the other should be discussed.

James to create a mockup for two line button.

Two lines - text left aligned. Icon on the first line.

2

Button

Nav style button padding appears to include a 1px padding. This is not a spacer value and is likely a design error that could be tweaked.

Outline style for all elements - change to 2px

3

Button

The outline offset for nav is hard coded at 1px. On other variant styles it is 4px. What is the reason that we don't have a common default value for styles like this? It doesn't look like line size, style, colour, outline value etc is referencing common token values to centralise the styles rather than adding them individually for each state.

Outline style for all elements - change to 2px

4

Link

Nav style link padding appears to include a 2px & 3px padding. This is not a spacer value and is likely a design error that could be tweaked.

Outline style for all elements - change to 2px

5

Link

Gap between text and icon size 6px and 9px. Can it be 4px and 8px ?

always 8px, if we find non-standard - just say

6

Image + Text

Inset variant. What is that bigger text in description ?

Add body text

7

Page Card

Standard variant, heading link with non-default style.

Elevation should be added on hover for cards

...